GOATS-966 GOATS-967 GOATS-968: Implement serializers for brightness, elevation range, and exposure mode. #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elevation range, and exposure mode. - Add GPPBrightnessesSerializer to handle brightnesses form data for GPP. - Add GPPElevationRangeSerializer to handle elevation range form data for GPP. - Add GPPExposureModeSerializer to handle exposure mode form data for GPP. - Update GPPTooViewSet to format and validate new input types from serializers. - Extend test coverage for new serializers and viewset methods. - Add utility functions for normalization of input data.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
==========================================
+ Coverage 76.62% 77.45% +0.83%
==========================================
Files 237 244 +7
Lines 7547 7834 +287
Branches 464 477 +13
==========================================
+ Hits 5783 6068 +285
- Misses 1676 1677 +1
- Partials 88 89 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR implements serializers and viewset methods to handle brightness, elevation range, and exposure mode form data for GPP ToO observations. It adds validation and formatting capabilities to transform flat form data into structured input types required by the GPP client.
- Adds three new serializers: GPPBrightnessesSerializer, GPPElevationRangeSerializer, and GPPExposureModeSerializer
- Updates GPPTooViewSet with formatting methods for the new input types
- Adds comprehensive test coverage for all serializers and viewset methods
- Includes utility functions for data normalization
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/goats_tom/serializers/gpp/test_exposure_mode.py | Test coverage for exposure mode serializer validation |
| tests/goats_tom/serializers/gpp/test_elevation_range.py | Test coverage for elevation range serializer validation |
| tests/goats_tom/serializers/gpp/test_brightnesses.py | Test coverage for brightness serializers |
| tests/goats_tom/api_views/gpp/test_toos.py | Test coverage for GPPTooViewSet formatting methods |
| src/goats_tom/static/js/gpp/gpp.js | Updates API call to pass form data without stringifying |
| src/goats_tom/static/js/api.js | Adds debug logging for POST requests |
| src/goats_tom/serializers/gpp/utils.py | Utility function for normalizing string inputs |
| src/goats_tom/serializers/gpp/exposure_mode.py | Serializer for exposure mode form data |
| src/goats_tom/serializers/gpp/elevation_range.py | Serializer for elevation range form data |
| src/goats_tom/serializers/gpp/brightnesses.py | Serializer for brightness form data |
| src/goats_tom/serializers/gpp/init.py | Module initialization for GPP serializers |
| src/goats_tom/serializers/init.py | Exports new GPP serializers |
| src/goats_tom/api_views/gpp/toos.py | Adds formatting methods to GPPTooViewSet |
| docs/changes/456.new.rst | Release note for the changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changesusing the PR number.